#616 PRs can be created from a few more places now
Merged by pingou. Opened by ryanlerch.
ryanlerch/pagure pr_links  into  master

Download 616.patch
no initial comment

The PR on the commits page is the same -- an alert at the top if the branch you are viewing is different to the upstream branch (or the main branch if you are not in a fork)

On the main overview tab, there is now a New PR button next to each branch that is different to the upstream branch (or the main branch if you are not in a fork)

The functionality on the PR tab page is a little different.
It allows you to file a PR against the current project you are looking at either from one of your forks, or if you have permissions, one of the branches in the non-forked project.

an example of the workflow is:

  1. I have a fork of the pagure codebase: ryanlerch/pagure
  2. i have made changes in ryanlerch/pagure branch master
  3. i go to the main pagure repo page (not the fork)
  4. go to the PR tab
  5. the new dropdown at the top right will allow me to create a new PR from the ryanlerch/pagure repo.

title pants?

This won't work when pagure isn't running at /

Same problem here

And here

This won't work, what if I want to create a remote PR to your fork?

hard-coded url with / here again

and here :)

the remote PR option will still show here, won't it? it does for me on a fork.

any thoughts on getting the templating url macros working in here? they require info from the ajax call, so they wont work. :( -- was just fixing up the /test/ boilerplate that was in there...

whoops, yeah this was a debugging thing -- forgot to pull it out

I normally use a fake branch='--**--' or so and then replace it with JS

Or like in : https://pagure.io/pagure/blob/master/f/pagure/templates/pull_request.html#_588

But the user should be the user of the project, not the user looking at the page

Looks good to me, so :+1:.

Some screenshots or something like that would make it much more easy to review.

Thanks for the review!

Metadata