I would keep the generic formula here as well

:thumbsdown: on these changes, first because they won't work, you linking the current folder with /srv/git and second because that's too specific to our setup.

Same here, too specific, might change, could very well be different on another distro

:thumbsdown: here as well, pagure works fine without. What we should do is include in the doc that they will need to install it if they want to use SSL.

If it's one of, maybe we could un-comment them here in the doc?

Maybe we will want in the future to add a small note on what this does

Does it need an empty line here?

and mod_ssl here I think

the email needs to be change to a dummy example one

I like very much the changes to the doc, but not so much the changes to the example configuration file.

But thanks a lot for working on this, highly appreciated :)

@pingou what should be done to get this in a merge-able state?

I would:

• Drop the changes in pagure.cfg.sample
• Drop the changes to the spec file
• Keep the line remove in alembic.ini
• Fix the three comments in doc/install.rst

And rebase so that we keep the history linear :)

@pingou Anything further need to be done here? I see there was an update to the PR since your last comment.

@ralph, as far as I can see none of my comments have been fixed :(

I'm not sure that agree-tos is a good thing to add here, since we tell users to do the equivalent of "I accept" without reading.

Also, why require mod_ssl?
There are enough cases where someone would want to use mod_nss.
We should instead just document how to use one or the other, and not force the user to one.

Note I don't think we need to document both, mod_nss users can figure it out themselves, but I do think we shouldn't force people.

This one has sat now for about 5 months with no response from the original submitter. Can we close this one?

Let's do that, I was hoping we could get it fixed but :(