From 492752ec96cdbe37a874c597be2beae9a8c0dbbc Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Feb 16 2016 10:48:47 +0000 Subject: [PATCH 1/2] By default the Web-hooks setting should be None, not False This has an influence on how it is show in the UI and therefore does matter. --- diff --git a/pagure/lib/__init__.py b/pagure/lib/__init__.py index d6139cd..e3cbb42 100644 --- a/pagure/lib/__init__.py +++ b/pagure/lib/__init__.py @@ -1228,7 +1228,10 @@ def update_project_settings(session, repo, settings, user): new_settings[key] = settings[key] else: update.append(key) - new_settings[key] = False + val = False + if key == 'Web-hooks': + val = None + new_settings[key] = val if not update: return 'No settings to change' From 6fc8eff06464fddfb4dc04a71c9a066bb611fdd1 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Feb 16 2016 10:48:47 +0000 Subject: [PATCH 2/2] When the setting requires an input, place the input field after the label --- diff --git a/pagure/templates/settings.html b/pagure/templates/settings.html index ee745a6..afdd793 100644 --- a/pagure/templates/settings.html +++ b/pagure/templates/settings.html @@ -211,9 +211,9 @@ {% else %}
+ -
{% endif %} {% endif %}