#899 Add a hook to block push missing 'Signed-Off-By' in at least one commit
Merged by pingou. Opened by pingou.
unsigned_hook  into  master

Download 899.patch
no initial comment

This fixes https://pagure.io/pagure/issue/303

Perhaps it's an idea to move this to the BaseHook?
Since the code that happens here seems generic enough that pretty much every hook would need it.

that would require two more global variables, the file in and the file out but that should be doable yes

Perhaps use: line.lower().startswith('signed-off-by: ') to make sure that it's at the start of the line rather than just a string in the middle of the text?

Works for me, I didn't know if that was a requirement. Maybe we could add a .strip() in the mix, in case

Sounds good yeah

Looks good to me. 可

Pull-Request has been updated

Thanks for the review :)

Pull-Request has been merged by pingou

Metadata