#939 Update changes summary, and files changed tab on Pull Requests
Merged by pingou. Opened by ryanlerch.
ryanlerch/pagure changes-summary  into  master

Download 939.patch

Here is a restyle and rework of some parts on the Pull Request Page.

  • Reworked the changes summary in the sidebar, making things fit a little better, and adding labels for the lines added and removed to make them green and red (issue #932)
  • added anchor links to each diff in the files_changed tab, and provide a link in the changes summary sidebar that points to the anchor, so you can click on it to vew the diff
  • reworked how we show if a file is renames in the changes summary (issue #887). Also added logic to show to the user if a file is added, or removed as well.
  • show the lines added and removed in each diff in the files changed tab
  • remove the "view" link, and put that link on the filename itself
  • added some logic to show a helpful message rather than an empty code display if:
    • a file is added, and it is empty
    • a file is renamed, but no change happened to the file part of issue #887

Here is the before and after shots of the same page:

After:

PR1_pants_-_pagure_-_Pagure_2016-05-03_18-44-22.png

Before:
PR1_pants_-_pagure_-_Pagure_2016-05-03_18-47-10.png

1 new commit added

  • Fix unit-tests

Ok I fixed the unit-tests, so this is looking good now.

Merging, thanks! :)

Pull-Request has been merged by pingou

Metadata