pagure

#995 Minor updates to milestone feature
Merged by pingou. Opened by lsedlar.
lsedlar/pagure milestone  into  master

Download 995.patch

The first commit changes label on button for adding milestones to no longer say priority.

The second makes it possible to have multiple milestones without dates. Originally there would be an error message Date is present 2 times when submitting the form, which is slightly confusing as there are no dates filled in.

The third commit changes the template to get rid of underline between the buttons on hover. Instead of using btn-default which is not defined in fedora-bootstrap I changed it to btn-secondary.

The different button can be seen on this video. It shows it both before and after the change.

Oups :D

Might be a good idea to add tests for this, could you look into it or do you prefer me to?

I will try to add the test.

rebased

I rebased this on current master and added the test, which did not pass before the patch and does pass with it.

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.