pungi

#1180 pungi-4.1.35 and 4.1.36 crash in resolving git url
Closed: Fixed by lsedlar. Opened by kevin.

Closed: Fixed
Reopen Issue

I updated the fedora rawhide-composer today. With pungi-4.1.35 or 4.1.36, rawhide compose runs gave: 

Cloning into 'pungi-fedora'...
Cloning into 'releng'...
Exception: ('Failed to resolve %s', 'https://pagure.io/releng/fedora-module-defaults.git')
Traceback (most recent call last):
  File "/usr/bin/pungi-koji", line 482, in <module>
    main()
  File "/usr/bin/pungi-koji", line 231, in main
    errors, warnings = pungi.checks.validate(conf)
  File "/usr/lib/python3.7/site-packages/pungi/checks.py", line 183, in validate
    for error in validator.iter_errors(config):
  File "/usr/lib/python3.7/site-packages/jsonschema/validators.py", line 105, in iter_errors
    for error in errors:
  File "/usr/lib/python3.7/site-packages/pungi/checks.py", line 308, in properties_validator
    instance[property]["repo"], instance[property].get("branch", "HEAD")
  File "/usr/lib/python3.7/site-packages/pungi/util.py", line 327, in __call__
    raise self.cache[key]
  File "/usr/lib/python3.7/site-packages/pungi/util.py", line 322, in __call__
    res = resolve_git_ref(url, branch) if branch else resolve_git_url(url)
  File "/usr/lib/python3.7/site-packages/pungi/util.py", line 275, in resolve_git_ref
    raise GitUrlResolveError("Failed to resolve %s", repourl)
pungi.util.GitUrlResolveError: ('Failed to resolve %s', 'https://pagure.io/releng/fedora-module-defaults.git')
real    0m2.046s
user    0m0.427s
sys 0m0.107s

Downgrading back to 4.1.33-3 and compose fires off ok.

I can resolve that host fine, I can git clone the url.

host pagure.io

pagure.io has address 152.19.134.147
pagure.io has IPv6 address 2605:bc80:3010:600:dead:beef:cafe:fed8
pagure.io mail is handled by 10 pagure.io.

git clone https://pagure.io/releng/fedora-module-defaults.git

Cloning into 'fedora-module-defaults'...
remote: Counting objects: 305, done.
remote: Compressing objects: 100% (166/166), done.
remote: Total 305 (delta 167), reused 270 (delta 135)
Receiving objects: 100% (305/305), 56.44 KiB | 418.00 KiB/s, done.
Resolving deltas: 100% (167/167), done.

The problem is that you specify master as a ref to check out, and there are two such refs in this repo:

$ git ls-remote https://pagure.io/releng/fedora-module-defaults.git master                               
3c1245c5f765a721807796567df3d325d10fb66c        refs/heads/master                                        
3b769c0d640e0095da374e59a46e3cd3b921ad18        refs/remotes/origin/master

I guess the list should be filtered to only include branches and tags...

Commit b0f0579a fixes this issue

The patch is included in pungi-4.1.36-2.fc29

Metadata Update from @lsedlar:
- Issue set to the milestone: 4.1.37

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/pungi/pungi/issues/1180

Please continue any further discussion there.
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.