pungi

#1884 Replace parametrized with pytest.mark.parametrize
Closed: Fixed by lsedlar. Opened by churchyard.

Closed: Fixed
Reopen Issue

Hello,
When updating pytest to 8.4 in Fedora, we realized that while pungi tests still pass in %check, tests of https://github.com/wolever/parameterized fail due to https://github.com/wolever/parameterized/issues/34, which was opened 9+ years ago.

With @music we were discussing orphaning the package; however, the pungi dependency worries me a bit. Would you mind replacing the use of that library with native pytest functionality?

I'm not opposed to dropping this dependency. We already depend on pytest, so it would make sense to unify tests around it.
However, the porting is not trivial and might take some time.
https://pagure.io/pungi/pull-request/1885 updates three of the four files using parameterized.
The remaining file is tests/test_scm.py, which is using a hierarchy of unittest.TestCase classes, which is not compatibly with pytest.mark.parametrize, and so the tests need to be rewritten in some way.

Thanks

Commit f8289718 fixes this issue

Thank you!

I made a new Rawhide build with the patch included. Older releases will be updated when a new upstream release is done (which doesn't have a timeline just yet).

Rawhide is the only impacted release, so no need to rush such a release for this.

Thanks.

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/pungi/pungi/issues/1884

Please continue any further discussion there.
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.