Issue #975: Deprecate runroot option - pungi

pungi

#975 Deprecate runroot option

Closed: Fixed Jun 27, 2019 by lsedlar. Opened Jun 7, 2018 by lsedlar.

The runroot option is currently required. However it does not seem useful. If runroot is enabled, the user has to specify runroot_tag. Pungi could just use that one option. If we have a tag to run in, use runroot, otherwise run things locally.

For backwards compatibility the option should be accepted for a few more releases, but emit a warning that it's no longer required.

Metadata Update from @lsedlar:
- Issue assigned to andilinux

Nov 22, 2018

hlin commented Jun 26, 2019

For backwards compatibility the option should be accepted for a few more releases, but emit a warning that it's no longer required.

PR https://pagure.io/pungi/pull-request/1224
Both 'alias' and 'append' could emit a warning, but seems them not matching this case.

After fixing this issue, I'm thinking making 'runroot_method' option mandatory with 'local' as default value and extra options are required according to different value of it, e.g. when runroot_method = 'openssh', runroot_ssh_* options should be set. I'm not sure if I understand it correctly. @lsedlar what's your opinion?

Edited Jun 27, 2019 by hlin

lsedlar commented Jun 27, 2019

Commit c4ed2bf3 fixes this issue

Metadata Update from @lsedlar:
- Issue set to the milestone: 4.1.38

Jul 2, 2019

lsedlar commented May 29, 2026

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/pungi/pungi/issues/975

Please continue any further discussion there.