#1 Re-architecture the entire project
Merged by pingou. Opened by pingou.
rearch  into  master

Download 1.patch
no initial comment

Please note that the type identifiers in Taskotron are all lowercase (it's not obvious from the documentation, because it's an enum class documentation, but the values are lowercase strings), maybe this could be the same? So koji_build, bodhi_update and pagure_pr.

1 new commit added

  • Make all identifiers lower case to be consistent with taskotron

Adjusted :)

This happens a lot, in reality, though https://taskotron.fedoraproject.org/resultsdb/results?testcases:like=org.centos.prod.ci.pipeline.*

Might be worth caching the data, as this gets called for the same result_id many times in sequence.

These aren't taskotron results, so you're not interested in these :)

Good idea, we can add dogpile in there

This method is called for any/all result_id though, from rats/lib/tasks.py lines 20/21, IIUIC. Not that this is any problem for how this works (it is IMO right), I just wanted to make sure the comment is not misleading for anybody that goes to optimize/restructure the code in the future :)

Would a rephrase to This should never happen in theory for taskotron's messages work or should I make it longer?

2 new commits added

  • Add caching using dogpile for results coming from resultsdb
  • Fix the comment that taskotron results should have a groups specified

Comment adjusted and caching added.

Do we want anything else?

3 new commits added

  • Improve the logging when processing requests
  • Let's not propagate the rats logging too much
  • Make RATS use the state field of flask-oidc to store information

5 new commits added

  • Make sure that we have the proper required data at the different time point
  • Finish the grace feature in RATS
  • Flake8 fixes all around
  • Remove some un-needed comments and debugging statements
  • Start working on preventing RATS to be abused to DDoS the test systems

Ok, this has been open for review for a while now but it seems it won't be reviewed :(

Since this application hasn't been released yet, I'm inclined to just go ahead and merge it, so we can move further ahead with it and test it in stg :)

Pull-Request has been merged by pingou

Metadata