#12810 Packages containg a "+" do not have a f42 branch
Closed: Fixed by james. Opened by fesoj.

I've noticed that packages containing a "+" do not have the f42 branch but do have a fc42 package. Package repos not containing a "+" in their name do have a branch f42.
And now I'm wondering how and why this happened. Is this a mistake, or was it on purpose?

Examples:

All have branches named up to fc41.

  • When do you need this?
    No deadline; this just happened to be a random observation.

  • If we cannot complete your request, what is the impact?
    Missing branches for packages in https://src.fedoraproject.org/rpms/ git repos


Metadata Update from @amedvede:
- Issue assigned to amedvede

Metadata Update from @jnsamyak:
- Issue tagged with: low-gain, low-trouble, ops

@amedvede, any updates on these sir, as mentioned this will be good to have this figured out before branching tomorrow, has any action was taken against it?

@amedvede, any updates on these sir, as mentioned this will be good to have this figured out before branching tomorrow, has any action was taken against it?

Still investigating what can cause this issue? I will try to fix it asap

The problem was that package name contained + was used in regex where + had different meaning, from f43 those packages will have a branch

Bug is fixed and now all active packages that contain + in their names have f43 branch, but it still needs to create f42 branch in some of them. I made a script that tells what active packages with + lack of f42 branch and maintainers of those packages https://amedvede.fedorapeople.org/releng_12810/result_package_list.txt . I'm planning to create a discussion post where the community can decide whether they want releng to request those branches or leave it to maintainers.

I don't know that it needs discussion, IMHO we should just fix the f43 ones too... it was expected that they exist and it was a bug in our script that didn't branch them.

I sent an email to devel list and asked whether maintainers would like us to recreate branches or if they will do it themselves.

By the discussion, we decided that we will recreate those branches. I will make a script that will make it

I created a script that will check a list of packages. If they are not retired, it runs request-branch command over them. https://pagure.io/releng/pull-request/12922 . For this case the list of packages is following https://amedvede.fedorapeople.org/releng_12810/plus_package_list.txt .
The problem is that to request a branch you need to be maintainer of package if you not request looks like this https://pagure.io/releng/fedora-scm-requests/issue/78130. So I either add myself as a maintainer, run script and remove myself as a maintainer later, but it will require many manual work. So what do you think will be the best approach?

Hum, yeah, good question.

Perhaps we can bypass the requests/toddler and just run the steps it does for this?

or... take the mass branching script and modify it to just mass branch these?

Yeah +1, if that is the case, being a maintainer, just use the mass-branching script I don't think adding another script for each task is necessary, it will clutter things up - https://pagure.io/fedora-infra/ansible/blob/main/f/roles/distgit/files/mass-branching-git.py. This is what we use for your reference.

@kevin thinking about it anton might need a ssh into pkg machine, what would you recommend?
Meanwhile, @amedvede I would say work on getting the script (as per the branching) we can test for one package if it works fine, we will do it for the rest packages. Make sure that f42 is not rawhide, rawhide is now f44, and branched is f43.

@kevin Both options might work, since @jnsamyak also recommends the second one, I'll stay with it, And Samyak is right, I don't have access to pkg machine, so I will ask someone to run the script instead of me when it is ready.

So, solution is:
1)Ssh to pkg machine
2) Clone and run https://pagure.io/releng/blob/main/f/scripts/branching/get_all_active_packages_branching.sh script
3) Take get_list_of_packages.sh from https://amedvede.fedorapeople.org/releng_12810/ and run it. grep command in terminal also works fine if its eazier.
4) Take need_to_request_branch.py from https://amedvede.fedorapeople.org/releng_12810/ modify the branch name in our case its f42 and f43 later. It will check if the package is lacking a branch and if it's not retired, after processing, it will generate list of packages for branching
5) Run https://pagure.io/fedora-infra/ansible/blob/main/f/roles/distgit/files/mass-branching-git.py script with the package list generated by the previous script and the corresponding branch name.

Can we consolidate it all in one script, since you already have the list, it should be a matter of work to tweak, the step 5 to branch only those packages?

Sure, good point. Now its tweaked. https://amedvede.fedorapeople.org/releng_12810/branch_packages.py
The script takes two arguments: the package list and the branch name

Issue tagged with: sprint-0

Finished running your script...

Had to remove the passed 3rd arg. to create_git_branch(), and add rpm/ to the start of all the lines in package_list.txt but apart from those minor things it seems to have worked fine.

Metadata Update from @james:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Thank you James!

Metadata