#9834 Can't push to a branch I have collaborator access to
Closed: Fixed by mohanboddu. Opened by xavierb.

  • Describe the issue
    I can't push to perl-Test-WWW-Mechanize epel8 branch, although I was granted collaborator access almost 3 weeks ago. I should have access to epel7 too, but I haven't tried.

  • When do you need this? (YYYY/MM/DD)
    Asap

  • When is this no longer needed or useful? (YYYY/MM/DD)
    Never

  • If we cannot complete your request, what is the impact?
    Can't push thus can't build perl-Test-WWW-Mechanize for EPEL 7 and 8

$ git push 
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: Fall-through deny
remote: Denied push for ref 'refs/heads/epel8' for user 'xavierb'
remote: All changes have been rejected
To ssh://pkgs.fedoraproject.org/rpms/perl-Test-WWW-Mechanize
 ! [remote rejected] epel8 -> epel8 (pre-receive hook declined)
error: failed to push some refs to 'ssh://xavierb@pkgs.fedoraproject.org/rpms/perl-Test-WWW-Mechanize'
Could not execute push: Failed to execute command.

https://src.fedoraproject.org/rpms/perl-Test-WWW-Mechanize
https://bugzilla.redhat.com/show_bug.cgi?id=1829977#c2
https://bugzilla.redhat.com/show_bug.cgi?id=1829995#c2


@pingou can you look at this o help see what my be missing?

Metadata Update from @smooge:
- Issue tagged with: medium-gain, medium-trouble, ops

@pingou Everything seems to be fine with pdc and collaborator access, can we debug it when you have time?

Metadata Update from @pingou:
- Issue assigned to pingou

Found it, bug in pagure-dist-git :)

Fixed in https://pagure.io/pagure-dist-git/pull-request/124

Alright, the new version of pagure-dist-git has been deployed in production. Could you try again and let us know how it goes?

Thanks @pingou
I was able to push and build for EL8, however Bodhi rejected my update request:

Builds : xavierb does not have commit access to perl-Test-WWW-Mechanize

However, I was able to create a build root override for this build:
https://bodhi.fedoraproject.org/overrides/perl-Test-WWW-Mechanize-1.52-7.el8

I was able to push and build for EL8, however Bodhi rejected my update request:
Builds : xavierb does not have commit access to perl-Test-WWW-Mechanize

Shoot!

That's a bodhi error/thing we need to fix and it won't be that easy to fix since one is about git branches pattern while the other is about distro version :(

Until we fix that, we might need to add "commit" access to EPEL maintainers who get access via the policy.

@ppisar was kind enough to request the branches for perl-Test-WWW-Mechanize, so I didn't see that earlier, but I'm now trying to request a branch for perl-Test-WWW-Mechanize-PSGI, which I was granted access to through https://pagure.io/releng/issue/9831 , and that was denied:

xavierb is not a maintainer of the perl-Test-WWW-Mechanize-PSGI package

See https://pagure.io/releng/fedora-scm-requests/issue/30282

See https://pagure.io/releng/fedora-scm-requests/issue/30282

This is also tracked in https://pagure.io/fedora-infrastructure/issue/9427

This should be fixed, could you confirm?

I've requested branches again, I'll let you know if it succeed or fail asap.

I've requested branches again, I'll let you know if it succeed or fail asap.

The branch request likely still fails, I meant git push.

oh, sorry, I misunderstood.
Yes, I was able to push to EL8.
See my earlier comment : https://pagure.io/releng/issue/9834#comment-699812

I was also allowed to build and request a build root override.
See https://pagure.io/releng/issue/9834#comment-699813

What I am not allowed to is
- request a branch (https://pagure.io/releng/issue/9834#comment-699924)
- submit an update (https://pagure.io/releng/issue/9834#comment-699836)

I'm going to close this ticket in favor of https://pagure.io/fedora-infrastructure/issue/9427 which tracks the branch request feature from collaborators and https://pagure.io/fedora-infrastructure/issue/9510 which track the bodhi angle.

Thanks for your report and help debugging the dist-git angle :)

Metadata Update from @pingou:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

I still can't submit an update in bodhi for perl-Test-WWW-Mechanize-1.54-1.el8.
Would be anyone from releng be so kind and file the request for me while I patiently wait for https://pagure.io/fedora-infrastructure/issue/9510 to be resolved or worked around ?
Also, an epel8 branch for perl-Test-WWW-Mechanize-PSGI in the wait of https://pagure.io/fedora-infrastructure/issue/9427 would be very appreciated too.

Metadata Update from @xavierb:
- Issue status updated to: Open (was: Closed)

@xavierb are you still encountering the push error?

I bring this up because I'm seeing something similar to your original issue, and am unable to push or merge PRs into a branch on a repo I work on.

I am a committer on the jmc repo [0], and am looking to push changes to the rpms/jmc/jmc branch [1] from my fork [2], and have tried going the PR route as well [3].

Unfortunately, when I try to push directly to the branch or merge the open PR I have, I am met with the following:

remote: 2021-01-13 21:36:34,992 [INFO] pagure.lib.git_auth: Looking for backend: distgit
remote: 2021-01-13 21:36:34,992 [INFO] pagure.lib.git_auth: Looking for backend: distgit
remote: 2021-01-13 21:36:34,999 [DEBUG] pagure.lib.git_auth: Found the following installed helpers {'test_auth': EntryPoint.parse('test_auth = pagure.lib.git_auth:GitAuthTestHelper'), 'gitolite2': EntryPoint.parse('gitolite2 = pagure.lib.git_auth:Gitolite2Auth'), 'gitolite3': EntryPoint.parse('gitolite3 = pagure.lib.git_auth:Gitolite3Auth'), 'pagure': EntryPoint.parse('pagure = pagure.lib.git_auth:PagureGitAuth'), 'pagure_authorized_keys': EntryPoint.parse('pagure_authorized_keys = pagure.lib.git_auth:PagureGitAuth'), 'distgit': EntryPoint.parse('distgit = dist_git_auth:DistGitAuth')
remote: 2021-01-13 21:36:34,999 [DEBUG] pagure.lib.git_auth: Found the following installed helpers {'test_auth': EntryPoint.parse('test_auth = pagure.lib.git_auth:GitAuthTestHelper'), 'gitolite2': EntryPoint.parse('gitolite2 = pagure.lib.git_auth:Gitolite2Auth'), 'gitolite3': EntryPoint.parse('gitolite3 = pagure.lib.git_auth:Gitolite3Auth'), 'pagure': EntryPoint.parse('pagure = pagure.lib.git_auth:PagureGitAuth'), 'pagure_authorized_keys': EntryPoint.parse('pagure_authorized_keys = pagure.lib.git_auth:PagureGitAuth'), 'distgit': EntryPoint.parse('distgit = dist_git_auth:DistGitAuth')
remote: 2021-01-13 21:36:35,063 [DEBUG] pagure.lib.git_auth: Returning helper <class 'dist_git_auth.DistGitAuth'> from backend key 'distgit'
remote: 2021-01-13 21:36:35,063 [DEBUG] pagure.lib.git_auth: Returning helper <class 'dist_git_auth.DistGitAuth'> from backend key 'distgit'
remote: 2021-01-13 21:36:35,082 [DEBUG] pagure.utils: User is a committer
remote: 2021-01-13 21:36:35,082 [DEBUG] pagure.utils: User is a committer
remote: 2021-01-13 21:36:35,128 [INFO] pagure_auth: Branch refs/heads/jmc is unsupported
remote: Branch refs/heads/jmc is unsupported
remote: Denied push for ref 'refs/heads/jmc' for user 'almac'
remote: All changes have been rejected

@pingou Does this error look familiar to you, or do you have any advice or ideas I could try? Thanks!

[0] https://src.fedoraproject.org/rpms/jmc
[1] https://src.fedoraproject.org/rpms/jmc/tree/jmc
[2] https://src.fedoraproject.org/fork/almac/rpms/jmc/tree/jmc
[3] https://src.fedoraproject.org/rpms/jmc/pull-request/24

Edit: er, I noticed that the root cause of the issue for pushing here is a bit different, but I thought it was in the same ball-park that I could tag onto this issue. If what I've posted above requires a separate issue then I can open one.

looking to push changes to the rpms/jmc/jmc branch

That branch does not exist on PDC so it does not let you push to it. Actually, looking at: https://src.fedoraproject.org/rpms/jmc/branches?branchname=master if the branch exist, it may have reached its EOL date.
So that would be a different issue from the one tracked here

Thanks for the info! I'll open a separate issue then

perl-Test-WWW-Mechanize-1.54-1.el8 has now been tagged into the trashcan, I can't even try to submit a bodhi update anymore.
I'm not sure of the status of the branch creation bug, so I've submitted a new one:
https://pagure.io/releng/fedora-scm-requests/issue/32965

Branch creation is still failing.

This is fixed now.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Metadata
Related Pull Requests