#47 robosignatory breaks with koji 1.23.0
Closed: Fixed by abompard. Opened by kevin.

in koji 1.23.0 tagHistory is gone.

**Deprecating list-tag-history and tagHistory**
| PR: https://pagure.io/koji/pull-request/938
These commands are superseded by ``list-history`` resp. ``queryHistory`` and
will be removed in near future.

Now they are removed.

Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: [fedora_messaging.twisted.protocol INFO] Consumin
g message from topic org.fedoraproject.prod.buildsys.tag (message id 39794349-e259-4675-83da-696971c8b2c5)         
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: [robosignatory INFO] Received message from fedora
-messaging with topic: org.fedoraproject.prod.buildsys.tag                                                         
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: [robosignatory.tagconsumer INFO] Build python-cys
ignals-1.10.2-10.fc34 (1641201) tagged into f34-build-side-33867-signing-pending on primary                        
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: [robosignatory ERROR] Invalid method: tagHistory:
 Unable to handle message: Id: 39794349-e259-4675-83da-696971c8b2c5                                                
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: Topic: org.fedoraproject.prod.buildsys.tag      
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: Headers: {                                      
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "fedora_messaging_schema": "base.message",  
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "fedora_messaging_severity": 20,            
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "sent-at": "2020-11-12T03:06:27+00:00"      
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: }   
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: Body: {
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "build_id": 1641201,
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "instance": "primary",
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "name": "python-cysignals",
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "owner": "jjames",
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "release": "10.fc34",
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "tag": "f34-build-side-33867-signing-pending",
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "tag_id": 33906,
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "user": "bodhi",
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     "version": "1.10.2"
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: }
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: Traceback (most recent call last):
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib64/python3.6/site-packages/koji/__init__.py", line 2754, in _callMethod
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     return self._sendCall(handler, headers, request)
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib64/python3.6/site-packages/koji/__init__.py", line 2672, in _sendCall
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     return self._sendOneCall(handler, headers, request)
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib64/python3.6/site-packages/koji/__init__.py", line 2718, in _sendOneCall
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     ret = self._read_xmlrpc_response(r)
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib64/python3.6/site-packages/koji/__init__.py", line 2730, in _read_xmlrpc_response
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     result = u.close()
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib64/python3.6/xmlrpc/client.py", line 656, in close
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     raise Fault(**self._stack[0])
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: xmlrpc.client.Fault: <Fault 1000: 'Invalid method: tagHistory'>
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: During handling of the above exception, another exception occurred:
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: Traceback (most recent call last):
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib/python3.6/site-packages/robosignatory/consumer.py", line 44, in __call__
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     self.tag_handler.consume(msg)
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib/python3.6/site-packages/robosignatory/tag.py", line 142, in consume
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     skip_tagging=False)
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib/python3.6/site-packages/robosignatory/tag.py", line 207, in dowork
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     koji_instance)
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib/python3.6/site-packages/robosignatory/tag.py", line 158, in match_sidetag
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     for hist_event in sorted(instance['client'].tagHistory(build_id),
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib64/python3.6/site-packages/koji/__init__.py", line 2346, in __call__
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     return self.__func(self.__name, args, opts)
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:   File "/usr/lib64/python3.6/site-packages/koji/__init__.py", line 2773, in _callMethod
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]:     raise err
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: koji.GenericError: Invalid method: tagHistory
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: [fedora_messaging.twisted.protocol WARNING] Returning message id 39794349-e259-4675-83da-696971c8b2c5 to the queue
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: [fedora_messaging.twisted.protocol INFO] Consuming message from topic org.fedoraproject.prod.buildsys.tag (message id 05e9f7a2-58f7-4d34-9454-6807e3063504)
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: [robosignatory INFO] Received message from fedora-messaging with topic: org.fedoraproject.prod.buildsys.tag
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: [robosignatory.tagconsumer INFO] Build dummy-test-package-crested-0-2163 (1641238) tagged into f34-build-side-33887-signing-pending on primary
Nov 12 04:14:21 autosign01.iad2.fedoraproject.org keyctl[2811707]: [robosignatory ERROR] Invalid method: tagHistory: Unable to handle message: Id: 05e9f7a2-58f7-4d34-9454-6807e3063504

We need to fix this fast...

CC: @pingou @abompard


Looks like this has been fixed by #48.

Metadata Update from @abompard:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Metadata
Related Pull Requests