robosignatory

#25 Create a consumer to sign CoreOS artifacts
Merged by abompard. Opened by abompard.
abompard/robosignatory coreos  into  master

Download 25.patch

This changeset adds a consumer to sign CoreOS artifacts.
I haven't tested it end-to-end yet because for now the CoreOS project does not produce the corresponding messages, but I think the code review can begin anyway.

Could we put the AWS credentials in the robosignatory configuration file as well?
That means you'll need to construct the boto3 client manually (rather than using the implicit default one), or manually configure the default one.
For reference, see setup_default_session in https://boto3.amazonaws.com/v1/documentation/api/latest/reference/core/boto3.html, together with https://boto3.amazonaws.com/v1/documentation/api/latest/reference/core/session.html#boto3.session.Session.client for kwargs values.

I think that we'll want to avoid using f.read(), since f could be a file image of many gigabytes in size.
I think we'll want to construct the sha256 hasher, and then read f in blocks, and pass that into the hasher.

1 new commit added

  • Fix review comments

Looks good to me.
Let's merge this, and then see based on actual testing (when possible) what to change before making a release.

rebased onto 19879bc71c9c7c38792cce4ea46198095976c24f

Pull-Request has been merged by abompard
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.