From 2e4b63881597d583793ff6e7d59aea28bdae0886 Mon Sep 17 00:00:00 2001 From: Patrick Uiterwijk Date: Feb 10 2017 14:30:13 +0000 Subject: When a build contains no rpms, still move it Signed-off-by: Patrick Uiterwijk --- diff --git a/robosignatory/tagconsumer.py b/robosignatory/tagconsumer.py index 44c0c63..c52fe48 100644 --- a/robosignatory/tagconsumer.py +++ b/robosignatory/tagconsumer.py @@ -117,10 +117,9 @@ class TagSignerConsumer(fedmsg.consumers.FedmsgConsumer): (key, rpms[key]['id'], rpms[key]['signed']) for key in rpms.keys()]) if len(rpms) < 1: - log.info('Build contains no rpms, skipping') - return + log.info('Build contains no rpms, skipping signing and writing') - if all([rpms[rpm]['signed'] for rpm in rpms]): + if all([rpms[rpm]['signed'] for rpm in rpms]) or len(rpms) < 1: log.debug('All RPMs are already signed') else: to_sign = [key for key in rpms.keys() if not rpms[key]['signed']] @@ -136,14 +135,15 @@ class TagSignerConsumer(fedmsg.consumers.FedmsgConsumer): '%s, stderr: %s', ret, stdout, stderr) return - log.info('Build was succesfully signed, telling koji to write with key' - ' %s', tag_info['keyid']) + if len(rpms) > 1: + log.info('Build was succesfully signed, telling koji to write with key' + ' %s', tag_info['keyid']) - for rpm in rpms: - instance['client'].writeSignedRPM(rpms[rpm]['id'], - tag_info['keyid']) + for rpm in rpms: + instance['client'].writeSignedRPM(rpms[rpm]['id'], + tag_info['keyid']) - log.info('Signed RPMs written out') + log.info('Signed RPMs written out') if skip_tagging: log.info('Tagging skipped, done')