robosignatory

#43 coreos: drop requirement on stream key
Merged by abompard. Opened by jlebon.
jlebon/robosignatory pr/drop-stream  into  master

Download 43.patch

RoboSignatory actually doesn't need to know the stream being signed at
all. I think the original rationale for this was so that we could tell
which stream was being signed for informational purposes. Nowadays: (1)
RoboSignatory returns all the keys in the request message in its
response, (2) FCOS stream information is encoded in the version ID
already, and (3) we're going to add idempotency request ID tokens to
track individual requests.

Signed-off-by: Jonathan Lebon jonathan@jlebon.com

Looks fine to me but I'll let @abompard have the final say :)

LGTM

Note, I've applied this in autosign01.stg.phx2.fedoraproject.org to unstuck robosignatory there (it was on a loop processing a messaging without stream and thus failing to process it, sending it back to the queue, picking it and repeat).

If this is actually applied, let's merge it to make sure it's in the tree?

rebased onto cb6a659c7961a29ee07f8cd635eb56ff6ed3046b

Pull-Request has been merged by abompard
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.