#20 RFE: Support signed tags
Closed by clime. Opened by erinn.

Currently it looks like signed tags are not properly supported, from my changelog with a mix of signed and unsigned:

iJMEABYIADsWIQRZezaxkyxyZ8XPSLCrERNNScL4YgUCXWfxax0cZXJpbm4ubG9v
bmV5dHJpZ2dzQGdtYWlsLmNvbQAKCRCrERNNScL4YiLFAQCeS0/uUBal8l94UJCd
f7r+d+CGWUQ+XrOCdvvSsKGwmAD9FByUtRnLlGvYbyXmn7eEMam5aAArZJOgfVPY
yvwDTQ0=
=BIYQ
-----END PGP SIGNATURE-----

iJMEABYIADsWIQRZezaxkyxyZ8XPSLCrERNNScL4YgUCXWfvYB0cZXJpbm4ubG9v
bmV5dHJpZ2dzQGdtYWlsLmNvbQAKCRCrERNNScL4Ypx1AQD9vITbk1SuFWC+jTSZ
gZX51mHzS3HdWYD8f3aSt1F2CgEArC0SEOHZvexGIp3sXlmyJa/9XyzS3XEgt52f
IqDpyAk=
=i0yG
-----END PGP SIGNATURE-----

I believe you get the idea. Maybe this is right, but it sure looks wrong. Would also like rpkg tag to support signing


Hey!

with what version did you try it?

Can you, please, try version from https://copr.fedorainfracloud.org/coprs/clime/rpkg-util/, which is basically the current master?

It should support signing automatically when you configure gpg_keyid in [git] section in rpkg.conf. I am not sure about the messed up changelog but hopefully that's fixed too..

I pulled in the latest build for the copr repo:
rpkg-3.prototype.git.117.3a9c9748-1.fc30.noarch

And added a ~/.config/rpkg.conf
[git]
gpg_keyid = 5BC306185D0B1E19

And I was indeed prompted to sign the commit, however the changelog in the spec file ended up like so:
%changelog
* Fri Aug 30 2019 Erinn Looney-Triggs erinn.looneytriggs@gmail.com 1.1-1
Testing.
-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRsdjRKIO/1XdOTSgF1uIQgdzwyZAUCXWkJfwAKCRB1uIQgdzwy
ZEHoAP9q0x68OoNK2MlGXHV/8TWEF+lMU3E26TasCLmiD/2RWAD+LGhEkVl0KUms
wi4v1Hm7rc62EoLABTmcPCVA371RegU=
=uNaq
-----END PGP SIGNATURE-----

Is including the signature intentional? I don't know. And finally the man page is very thorough, I appreciate that, but it seems to be a bit out of sync with https://docs.pagure.org/rpkg-util/index.html I had no idea the rpkg.conf existed.

Yeah, including the signature in the changelog is not intentional - will fix that, thanks!

https://docs.pagure.org/rpkg-util/index.html is for rpkg 2.7 and actually i can see even now it's missing an entry on configuration. Will fix that too, thanks!

Hello, i've fixed the issue in https://pagure.io/rpkg-util/c/d3b62ac82d7e56bfd326d52788f6667ddf6707f6?branch=fix_issue_20. I also lanuched a rebuild of the rpkg-macros package is in clime/rpkg-util-3-prototype in the copr repo.

Let me know if if you find out this doesn't work.

Metadata Update from @clime:
- Issue status updated to: Closed (was: Open)

This issue has been migrated to GitHub: https://github.com/fedora-copr/rpkg-util/issues/20
Don't forget to subscribe for notifications about new comments.

Metadata