rpkg

#18 unused-patches is broken
Closed: Fixed Opened by crobinso.

Closed: Fixed
Reopen Issue

Running 'fedpkg unused-patches' on f23 gives me this:

$ fedpkg --verbose unused-patches
Creating repo object from /home/crobinso/src/fedora/qemu
Could not execute unused_patches: 'ascii' codec can't decode byte 0xc3 in position 37854: ordinal not in range(128)
Traceback (most recent call last):
  File "/usr/bin/fedpkg", line 16, in <module>
    main()
  File "/usr/lib/python2.7/site-packages/fedpkg/__main__.py", line 68, in main
    sys.exit(client.args.command())
  File "/usr/lib/python2.7/site-packages/pyrpkg/cli.py", line 1198, in unused_patches
    unused = self.cmd.unused_patches()
  File "/usr/lib/python2.7/site-packages/pyrpkg/__init__.py", line 2306, in unused_patches
    spec = spec.replace("%{name}", self.module_name)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 37854: ordinal not in range(128)

The attached patch fixes it

0001-Fix-unused-patches.patch

Ping, any comment here?

For reference this issue doesn't affect all packages, just those with non-ascii in their specfile

Thanks for the patch. There already was a pull request open for fixing this issue, which I just merged.

Thank you, indeed that pull request is much nicer than my patch
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.