#333 When interrupting a build, the watch-tasks message provides the incorrect command
Closed: Fixed by lsedlar. Opened by tmz.

An example:

$ fedpkg build --scratch --srpm
[...]
Building git-2.18.0-0.2.1.rc2.fc29.src.rpm for rawhide
Created task: 27744452
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=27744452
Watching tasks (this may be safely interrupted)...
[...]
^CTasks still running. You can continue to watch with the 'fedpkg watch-task' command.

(To be clear, the issue is that "fedpkg watch-task" is returned instead of "koji watch-task" since there is no fedpkg watch-task command.)

This comes from koji_cli.lib.watch_tasks, so the fix likely involves coordination with koji. It seems like it might be ideal if koji's watch_tasks accepted an argument to set progname which took precedence over the sys.argv[0] or 'koji' currently used.

I don't know if rpkg could override sys.argv before calling watch_tasks or not. I didn't follow all the code to see whether there is anything which can be reached after the build() call and needs sys.argv. (That obviously seems like a gross hack. ;) ).

Other options which come to mind:

  • add a watch-task subcommand which is a simple pass-through to koji watch-task
  • catch the koji watch_tasks() output and replace the command name

I'm not saying those are good options. just things that came to mind.


There is a koji PR to make it possible to customize watch_tasks. Let's wait for it to be released.

Has to start after koji PR#981

Nice, I'm glad to see there's a koji PR in progress. Thanks! :)

This should be fixed as of python-rpkg 1.59.

Metadata Update from @lsedlar:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Metadata Update from @onosek:
- Issue set to the milestone: 1.59

Metadata