#533 better "new-sources" output when all sources already exist
Closed: Fixed by onosek. Opened by ktdreyer.

When I run fedpkg new-sources for upstream sources that another package co-maintainer has already uploaded, fedpkg prints a misleading message "Source upload succeeded. Don't forget to commit the sources file", even when my fedpkg invocation actually uploaded nothing and there is no change to commit to Git.

Steps to reproduce

  1. Check out any package where the upstream source is already uploaded
  2. Run fedpkg new-sources on the already-uploaded source tarball.
  3. Note the fedpkg output

Actual results
fedpkg prints "Source upload succeeded. Don't forget to commit the sources file"

Expected results
fedpkg prints "All sources were already uploaded." It should not say anything about uploads "succeeding" or committing a sources file when there are no new changes to commit.


Commit 55caa85a fixes this issue

Metadata Update from @onosek:
- Issue set to the milestone: 1.63

Metadata
Related Pull Requests