#732 When rpmlint errors, should print all output
Closed: Fixed by onosek. Opened by sgallagh.

Currently, the pre-push-check only prints the stderr output from rpmlint if it encounters a parsing error. This led to confusion today when we got the cryptic error "error: line 346: second check" when a bad rebase had resulted in two %check sections.

"second check" was not sufficient information to work with (I assumed it was someone's leftover printf debugging statement, not realizing for quite a while that it was actually the source of the failure).

When rpmlint returns non-zero, rpkg should print both the stderr and stdout output which would have included the much more helpful content:

podman.spec: E: specfile-error error: line 337: second check
podman.spec: E: specfile-error error: query of specfile podman.spec failed, can't parse
podman.spec: E: specfile-error can't parse specfile podman.spec

Hi,
I was a little confused with rpmlint mention. I believe the issue is with the spectool which is run during pre-push-check. This is a potential fix.
https://pagure.io/rpkg/pull-request/733

Commit 3e39a8a0 fixes this issue

Metadata Update from @onosek:
- Issue set to the milestone: 1.68

Metadata
Related Pull Requests