rpkg

#105 New --release option
Merged by cqi. Opened by cqi.
cqi/rpkg new-option-release  into  master

Download 105.patch

Introduce a new global option --release to represent what --dist does. This is
a replacement, --dist will be disabled eventually after a while.

Original --dist is used to overwrite the name got from remote branch, and then
determine the build target and dist macro to build RPM. Where the name is
actually the release name, e.g. f24 and f25. Hence, --release could be much
clear and easier for users to know what behavior it will affect.

Signed-off-by: Chenxiong Qi cqi@redhat.com

After this patch pass review and is merged, downstream client tools including fedpkg and rhpkg will be modified to extend --release help by adding more information so that help message can be suitable for specific package tool.

rebased

Could anyone review?

The code change looks good. I'm not sure how viable removing --dist: there are most likely people with scripts that use that option. However, adding --release as a more user friendly name seems like a good improvement.

I'm not sure how are people going to find out that --dist is deprecated. With this patch it's only advertised in the help output, which most people probably don't use that often (and definitely don't use if they have a script that calls Xpkg for them). Should it maybe print a warning each time the deprecated option is used?

rebased

Patch is updated with deprecation warning. This is applicable when run fedpkg or rhpkg with --dist.

That's a clever way to do it. I like it. +1

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.