rpkg

#193 More upload PyCURL fixes for EL 7
Closed by lsedlar. Opened by merlinthp.
merlinthp/rpkg pycurl_unicode  into  master

Download 193.patch

A couple more values need converting from unicode to str in
remote_file_exists() and upload().

Signed-off-by: Howard Johnson merlin@merlinthp.org

Code looks good to me.

How about

if isinstance(s, six.text_type):
    s = s.encode('utf-8')
Edited by cqi

Happy to change it, although I was matching the syntax lsedlar used in his previous fix :)

Given that we don't a good way to test this (that we would consistently use); I think it's better to stay as explicit as possible about what's going on.

I have rebased this on master and merged it via #200. Thank you for the patch!

Pull-Request has been closed by lsedlar
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.