rpkg

#245 Use koji.grab_session_options() rather than opencoding it
Merged by cqi. Opened by teuf.
teuf/rpkg master  into  master

Download 245.patch

create_koji_session_opts() is doing the same as
koji.grab_session_options() (introduced with koji 1.11), but fails to
handle the 'serverca' and 'no_ssl_verify' options, potentially causing
SSL verification failure if one tries to use them.

koji.grab_session_options() does not have this problem, and this allows
us to kill a bit of code.

Signed-off-by: Christophe Fergeau cfergeau@redhat.com

koji_config is dict, whereas koji.grab_session_options accepts parameter options that is returned from parse_args.

koji.grab_session_options handles its 'options' argument as a dict as far as I can tell, it only uses hasattr(options, ...) and getattr(options, ...). Looking at the 2 methods, their implementation looks very similar to me.

Run a scratch build successfully with this change. :thumbsup:

Commit 7a636ec0 fixes this pull-request

Pull-Request has been merged by cqi

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.