LGTM

I'm confused totally. Can you provide more information about the background? What problem does this PR aim to solve? Why remove --module-name option?

ODCS supports modules as well in container.yaml file.

So in order to have just one way of using modules in OSBS,
flatpak will use it via container.yaml.

We won't be using modules from args for flatpaks only.

--module-name was not dedicated for module build and even the flatpak. Here is its explanation

  --module-name MODULE_NAME
                        Override the module name. Otherwise it is discovered
                        from: Git push URL or Git URL (last part of path with
                        .git extension removed) or from name macro in spec
                        file. In that order.

the part of module could be kind of ambiguous nowadays though.

So in order to have just one way of using modules in OSBS,
flatpak will use it via container.yaml.

We won't be using modules from args for flatpaks only.

Is there something wrong that fedpkg does not work for you to use modules in OSBS?

Ahh ok, I can see now that it isn't used for container-build

closing this