PR#38: properly handle koji urls vs distgit when distgit is namespaced -

rpkg

#38 properly handle koji urls vs distgit when distgit is namespaced

Closed Mar 16, 2016 by lsedlar. Opened Mar 15, 2016 by maxamillion.

maxamillion/rpkg distgit-namespace into master

no initial comment

maxamillion commented Mar 15, 2016

Signed-off-by: Adam Miller maxamillion@fedoraproject.org

lsedlar commented Mar 15, 2016

I agree we probably need to keep module names both with namespace and without. However, I would prefer to keep module_name with the old meaning (without namespace). That way should be less fragile as namespaces will only be introduced on opt-in basis.

I updated #38.

Pull-Request has been updated

Mar 15, 2016

Pull-Request has been rebased

Mar 16, 2016

lsedlar commented Mar 16, 2016

Missing underscore in ns_module name.

lsedlar commented Mar 16, 2016

Looks good to me. Can you please squash the commits so that we don't have dead ends in history?

Pull-Request has been rebased

Mar 16, 2016

maxamillion commented Mar 16, 2016

rebased and squashed

Pull-Request has been rebased

Mar 16, 2016

Pull-Request has been closed by lsedlar

Mar 16, 2016

Metadata

Assignee

None

Tags

No Tags

rpkg

#38 properly handle koji urls vs distgit when distgit is namespaced Closed Mar 16, 2016 by lsedlar. Opened Mar 15, 2016 by maxamillion. maxamillion/rpkg distgit-namespace into master

Metadata

#38 properly handle koji urls vs distgit when distgit is namespaced

Closed Mar 16, 2016 by lsedlar. Opened Mar 15, 2016 by maxamillion.

maxamillion/rpkg distgit-namespace into master