When watching builds, the dictionary to track module build progress was not populated with tracking information due to an early 'continue' statement.
This caused watching builds fail when builds transitioned from 'init' to 'build' state between two watch cycles, with:
Could not execute module_build: 'tasks_stats'
This happened when building modules without any components and starting the watch as soon as the build was submitted.
Treating 'init' as any other state solves this issue, as the 'build' branch in 'module_watch_build()' will find tracking information pre-populated.
This is safe to do since 02affb4: we won't fail on an empty 'tasks' dictionary.
Signed-off-by: Hunor Csomortáni csomh@redhat.com
@onosek @mulaieva ptal
OK, it is going to be merged.
Commit 5cce3d59 fixes this pull-request
Pull-Request has been merged by onosek
When watching builds, the dictionary to track module build progress was
not populated with tracking information due to an early 'continue'
statement.
This caused watching builds fail when builds transitioned from 'init' to
'build' state between two watch cycles, with:
This happened when building modules without any components and starting
the watch as soon as the build was submitted.
Treating 'init' as any other state solves this issue, as the 'build'
branch in 'module_watch_build()' will find tracking information
pre-populated.
This is safe to do since 02affb4: we won't fail on an empty 'tasks'
dictionary.
Signed-off-by: Hunor Csomortáni csomh@redhat.com