rpkg

#96 New source code layout
Merged by cqi. Opened by cqi.
cqi/rpkg new-layout  into  master

Download 96.patch

  • Tests are in src/ directory.

  • Bash completion and configuration file are in dedicated directory.

  • Script to generate manpage are moved to docs/.

Signed-off-by: Chenxiong Qi cqi@redhat.com

This change also benefits developers, that is to run python setup.py test directly in RHEL6/7 and Fedora.

Tests pass, building Fedora RPM (for Rawhide) from the new tarball seems to be working as well (I only needed to change path to man page script and set PYTHONPATH so that it would find pyrpkg.cli module).

Does the src/ directory make sense anymore? There are only other subdirs in it, so maybe those could be moved to top level?

Generally this looks fine to me.

rebased

Does the src/ directory make sense anymore? There are only other subdirs in it, so maybe those could be moved to top level?

Good idea. Patch is updated.

The tests pass on my machine. It looks like there are some stale .pyc files.

LGTM

It looks like there are some stale .pyc files.

in src/ directory?
Edited by cqi

When I pulled this PR locally and ran the tests, I got the same error, but git clean -fxd fixed it. I don't know if this really is the problem.

src/ needs to be deleted.

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.