#69 Conditionally use ldconfig scriptlets from the library template
Merged by ngompa. Opened by salimma.
salimma/rpmdevtools lib-no-ldconfig  into  master

Download 69.patch

This has not been needed since Fedora 28; instead of hardcoding the scriptlet, conditionally expand %{?ldconfig_scriptlets} if it's defined.

https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

Signed-off-by: Michel Alexandre Salim salimma@fedoraproject.org

This is still needed on EPEL 7, though...? And openSUSE has no file triggers for this either...

That said, I think I'd be okay with changing this to %{?ldconfig_scriptlets} instead...

Ack, let me check if that works

$ mock -r epel-7-x86_64 shell
<mock-chroot> sh-4.2# rpm -E %{?ldconfig_scriptlets}
%post -p /sbin/ldconfig                
%postun -p /sbin/ldconfig      
<mock-chroot> sh-4.2#
$ mock -r fedora-33-x86_64 shellINFO: mock.py version 2.6 starting (python version = 3.9.0)...
<mock-chroot> sh-5.0# rpm -E %{?ldconfig_scriptlets}
<mock-chroot> sh-5.0#

yup, that should work

1 new commit added

  • Use %{?ldconfig_scriptlets} to conditionally use scriptlets if defined

Can you clean up your commits? Once you do so, I'll merge it.

rebased onto 0168bdfdc7f2e74432a71aa1349fa852118611ee

Commits squashed

Pull-Request has been merged by ngompa

Metadata