rebased onto 125ee84f55f7f004128e023c6db2ceade2230f35
LGTM
I'd add a license file placeholder. Recently, I found a GPL package that was imported to Fedora without any license file :(.
See the fixup commit.
1 new commit added
fixup! Add a spec template for pyproject-rpm-macros
Good point about the %pyproject_files part. I always forget that. I'd probably include a slash between the second COPYING and LICENSE, but meh. Maybe also add how to check (rpm -qpL foo.rpm)?
COPYING
LICENSE
rpm -qpL foo.rpm
2 new commits added
Add a spec template for pyproject-rpm-macros
Slash removed. I want to keep the comments to a minimum, this is not a guide but a template.
rebased onto 9f61a65cbcf3d51624ff25aa631835662e7aadf8
Fair enough. Thanks!
Looks fine to me. Theoretically multiple distributions could be using the pyproject macros, so...
Pull-Request has been merged by ngompa