#42 Import error raised on new RPMFuff version
Closed: Fixed by jkonecny. Opened by jkonecny.

Hello,

It's great to see more development on this project. However, with your new release our tests are failing.

    from rpmfluff import SourceFile, GeneratedSourceFile, SimpleRpmBuild, expectedArch, make_elf
ImportError: cannot import name 'expectedArch'

We're hitting this in our tests. Is this a bug in RPMFluff or an intentional change?


It's happening in this commit:

https://pagure.io/rpmfluff/c/54714a511baa4421c32dad68cacc9ce019e1157b?branch=master

Based on how this commit looks like it is intentional that this release will break imports. Is that correct?

Another issue is the make_elf import.

Hello. It was quite a big change and we do not have tests for this kind of stuff. Please try now - did this commit:

https://pagure.io/rpmfluff/c/2bc98ec074314ed916439739994a766f96455eab?branch=master

Works great! Thanks a lot! Could you please make a release with this soon?

Hello @jkonecny. I have release 0.6.1 with these changes. It should be in PyPi and in Rawhide

Metadata Update from @jhutar:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Great thanks!

Tested and it works great now. Thanks a lot for quickly fixing this!

Metadata Update from @jkonecny:
- Issue status updated to: Open (was: Closed)

Metadata Update from @jkonecny:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Metadata