The exception e kept returning as an OSError instead of a github API error. That is why I had to use e.__str___() instead of comparing the type of exception directly.

Probably not supposed to be here? Is it not handled by the log.debug line?

You may want a block here that does:

else:
    raise

So that you re-raise the exception just exactly as it was in the case that "API rate limit ..." is not in the exception string.

Probably not supposed to be here? Is it not handled by the log.debug line?

Yup this was used to test locally. I'll change it.

You may want a block here that does:
else:
raise

So that you re-raise the exception just exactly as it was in the case that "API rate limit ..." is not in the exception string.

Ah thats a good idea! Might also make sense to report_failure as well if its not a Github error.

TODO for myself:
- Update the tests to capture this possibility.

@ralph this is ready for a final review.

Added a testing flag so when we test the function we don't get caught in a recursive loop

:+1: