From 7e6dc5dffbc2922b863febf2ec0d61d54577bc84 Mon Sep 17 00:00:00 2001 From: sidpremkumar Date: Jul 10 2019 14:21:19 +0000 Subject: adding appropriate test cases --- diff --git a/sync2jira/downstream.py b/sync2jira/downstream.py index 30e0fe6..3d3313b 100644 --- a/sync2jira/downstream.py +++ b/sync2jira/downstream.py @@ -133,7 +133,7 @@ def _matching_jira_issue_query(client, issue, config, free=False): if check_comments_for_duplicate(client, result): final_results.append(result) # If that's not the case, check if they have the same upstream title - # Upstream username/repo can change if repos are merged + # Upstream username/repo can change if repos are merged elif re.search(r"\[[a-zA-Z0-9!@#$%^&*()_+\-=\[\]{};':\\|,.<>\/?]*\] " + issue.upstream_title, result.fields.summary): @@ -164,7 +164,6 @@ def check_comments_for_duplicate(client, result): return True - def _find_comment_in_jira(comment, j_comments): """ Helper function to filter out comments that are matching diff --git a/tests/test_intermediary.py b/tests/test_intermediary.py index b521339..3978ec9 100644 --- a/tests/test_intermediary.py +++ b/tests/test_intermediary.py @@ -126,5 +126,5 @@ class TestIntermediary(unittest.TestCase): self.assertEqual(response.reporter, 'mock_reporter') self.assertEqual(response.assignee, 'mock_assignee') self.assertEqual(response.status, 'Open') - self.assertEqual(response.id, 1234) + self.assertEqual(response.id, '1234') self.assertEqual(response.downstream, 'mock_downstream')