sync-to-jira

#76 Adding support to email owners in the situation that duplicate issues are found
Merged by sidpremkumar. Opened by sidpremkumar.
sidpremkumar/sync-to-jira alert-owner-email  into  develop

Download 76.patch

When the optional owner field is set sync2jira will alert the owner (via email) if any duplicate issues are not closed.

1 new commit added

  • Mailer gets config values from enviormental variables

Nice!

Can you add an additional config option for a list of global admins (i.e., rbean@email.com and spremkum@email.com) such that we get cc'd on all these notifications.

I can imagine a situation where an owner of a downstream project will get one of these emails, and they would want to reply-all to ask "what am I supposed to do about this?"

1 new commit added

  • adding admin support for emails

This Mailer().method(...)is an anti-pattern in my opinion.

https://www.youtube.com/watch?v=o9pEzgHorH0

Consider removing the class, and keeping only the callable such that in this module you would write from sync2jira.mailer import send_mail and then send_mail(recipients=....).

Consider the comment above. It's not a blocker. You have my :+1: to merge without changing anything.

1 new commit added

  • Removing mailer class and replacing with static class

+1 to that idea. Changed it in the last commit

4 new commits added

  • Removing mailer class and replacing with static functions
  • adding admin support for emails
  • Mailer gets config values from enviormental variables
  • Adding support to email owners in the situation that duplicate issues are created

4 new commits added

  • Removing mailer class and replacing with static function
  • adding admin support for emails
  • Mailer gets config values from enviormental variables
  • Adding support to email owners in the situation that duplicate issues are created

Pull-Request has been merged by sidpremkumar
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.