Fix the download() function in file_utils.py, so it provides a way to specify both dirname and filename arguments. At the moment, there is just "dest" which can be ambivalent sometimes.
download()
file_utils.py
The expected behavior is that dirname is always required. If the directory does not exist, it gets created. filename is either provided as an argument, or if the argument is set to None (default value), then it is infered from the URL in the same way as at the moment.
dirname
filename
None
Once this is fixed, please also adjust all uses of this method in taskotron and tasks. At the moment of creation of this ticket, it is only used in libtaskotron/koji_utils.py/get_nvr_rpms()
libtaskotron/koji_utils.py/get_nvr_rpms()
This ticket had assigned some Differential requests: D154
Look at D136 to see the temporary workaround (and a long comment) introduced by @jskladan to avoid this issue.
Closing (D154).
Metadata Update from @jskladan: - Issue tagged with: easyfix