#421 Use generic Makefile provided by qa-make
Opened by frantisekz. Modified
makefile  into  develop

Download 421.patch

Everything looks like it's working just fine. I've added fix (separate commit) that allows to build docs without using virtual_env.

qa-make: https://pagure.io/fedora-qa/qa-make

I'll remove dodo after the review :)

$ make test
set -e
source /bin/activate;
TEST='true' py.test --cov-report=term-missing --cov ;
deactivate
/bin/sh: line 1: /bin/activate: No such file or directory
make: *** [Makefile:56: test] Error 1

Perhaps Makefile.cfg is missing?
Also, we want to run tox (as we do in dodo.py, not py.test).

For building docs, we used to call pushd docs && make html, now you call just sphinx-build. But that doesn't build directives (see docs/Makefile). Also, I believe this needs to run in virtualenv, otherwise you need to have all libtaskotron dependencies installed locally on your computer (sphinx imports all the modules).

I don't see any command to clean the docs.

It would be nice if the commands activating venv found first check if they're not already in an active venv (and that case just skipped it).

There are other smaller issues, like $(VENV) target hardcoding --system-site-packages (that should be project specific), or pep8 target hardcoding paths. But those are tiny details.

I'm not sure if we can really make a universal Makefile across all our projects, without making it really complex with everything configurable (and for that, heresy heresy, might be doit a better fit:)). Do you think you can fix the mentioned issues without making the universal Makefile overly complex?

Metadata