#119 Require basic authentication for POST requests
Merged by frantisekz. Opened by csomh.
taskotron/ csomh/resultsdb basic-auth  into  develop

Download 119.patch

This updates the OpenShift test template to require basic authentication for POST requests.

rebased onto 2e77df614241c7528bf9b4599deea037ec0af0ac

@csomh can you please rebase this?

rebased onto 60a75288aa52b7efb7b2dc1bebcba3e1781e4a68

@mcurlej better late, then never :) Rebased.

rebased onto 94287e36afca06824354fe7e543ce01b64fcf136

This is a very old PR, but still relevant.

@lholacek @ralph is it ok to merge?

Can you make the file readable only by httpd/apache? (owner=apache group=apache mode=0600)

+1 but someone else should also review.

Hm, I don't know how I would do that in OpenShift....

This file is mounted as a volume created from a secret. defaultMode could be set to 0600, but I'm not sure what the ownership of the files will be.

rebased onto 51921971312d252705bd531237849058cfe888a1

Updated so that defaultMode is 0600 for files mounted in /etc/resultsdb.

Also updated README.md to tell about .htpasswd.

rebased onto f4671ed01043a6951a85116d40a3cc6c9b4699fb

@frantisekz Can you help review this? This may be required in the future to allow resultsdb-listener to create results in ResultsDB. I think the access is currently based on IP/allowed_hosts filter which means it would not be possible to move resultsdb-listener to OpenShift.

cc @vmaljulin

@lholecek Sorry for such a long delay.

+1, this looks good to me (after rebasing).

However, I am far from being an OpenShift expert (and even then, I am deploying resultsdb into OpenShift via s2i) :)

@frantisekz +1 to merge this now. We can fix any issues later - I don't think this is yet used anywhere.

rebased onto a96a26cbb2b3516c69898eccbb7ee0ccfababae1

Pull-Request has been merged by frantisekz

Metadata