taskotron / resultsdb

#137 Make tox work without tox-docker
Closed by csomh. Opened by csomh.
taskotron/ csomh/resultsdb easy-tox  into  develop

Download 137.patch

This will make tox-docker optional for running the tests. In case
tox-docker is not installed, tox ignores the docker configuration for
the test environment.

When the above happens the POSTGRES_5432_TCP environment variable will
be missing. This can be used as a condition for pytest.mark.skipif to
skip the tests which need PostgreSQL running.

The above should improve developer experience.

Signed-off-by: Hunor Csomortáni csomh@redhat.com

What do you think, @jskladan?

Awesome! I got so worked up with that, trying to work around it, that this obvious path did not even cross my mind :)

Looks good "on paper", I'll give it a go once I have my laptop, and merge it then.

Thanks a lot!

@jskladan is this ok to be merged? :)

rebased onto 5980ae7465b644d143e4f1aaa37d3310a66d7f5a

Rebased. @jskladan do you mind if I merge this?

Sure, looks OK to me. Thanks @csomh

Hm, I think this is not needed anymore. Closing.

Pull-Request has been closed by csomh
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.