This should help debug issues if needed
Sort of related to issue #96
I'll admit I have trouble running the testsuite - tox passes but pytest fails to run even in virtualenv. Would need to look into it...
:+1:, this will help. :)
@sochotni Not really sure what your issue with the testsuite is, I just ran it without any issues: virtualenv --no-site-packages /tmp/vrtest source /tmp/vrtest/bin/activate pip install -r requirements.txt python setup.py develop py.test testing/
All of the above executed from a fresh git-checkout of the develop branch.
I'd rather see this as debug level.
debug
The project's line lenght is set to 99 chars, please unwrap.
sigh once again, Pagure's UX fails me...
The patch, as is, looks fine, if the comments above get addressed.
My question here, though, is what is the "grand scheme" here? Seems like it is just half-done, as the debug logs you added do not cover all the "this went wrong" (= where non-2xx HTTP status code is returned) cases in the code. I'd much rather see us logging in all the cases, as this could have the "I see no errors in the debug log, but it still does not work, what the heck?!?" effect quite easily.
Thanks!
@sochotni Not really sure what your issue with the testsuite is, I just ran it without any issues: virtualenv --no-site-packages /tmp/vrtest source /tmp/vrtest/bin/activate pip install -r requirements.txt python setup.py develop py.test testing/ All of the above executed from a fresh git-checkout of the develop branch.
For some reason pytest-cov >= 1.6 from requirements.txt didn't actually work? I had to manually install python2-pytest-cov from rpm
I agree logging as a whole could use a boost - as things are I don't think you'll get much out of logs even if you turn on debug. I'd be very much in favor of adding much more logging. This was just adding it in place where I could have just find it useful :-)
As an example - we have a few prod services with debug logs enabled and logs go directly into ELK. Value of this is immense when something goes wrong. We don't even need access to the machine and know exactly what happened. And generally for most systems the amount of generated logs is of no consequence.
Will address the comments in a bit
Weird, works for me with the virtualenv: $ rpm -qa | grep cov $ which coverage /tmp/vrtest/bin/coverage
But I'm glad you were able to find/fix the issue!
rebased onto 7e5ca61634d18123fb5f1039e534f82626d37022
rebased onto 0a93eddeb0122e94a117572088450f47e7100bf2
Unwrapped the lines and added few more debug statements for early returns
Awesome, thanks. I think this is a great start for even more excessive logging, should you/we ever need it. Will merge shortly.
Pull-Request has been merged by jskladan
This should help debug issues if needed
Sort of related to issue #96
I'll admit I have trouble running the testsuite - tox passes but pytest fails to run even in virtualenv. Would need to look into it...