waiverdb

#150 Make urlparse import py2/py3 friendly.
Merged by dcallagh. Opened by ralph.
urlparse-py2-py3  into  master

Download 150.patch

I noticed this when trying to run the greenwave functional tests
tonight. greenwave tries to import both waiverdb and resultsdb to
stand them up as text fixtures and it seems that (without this
change) waiverdb is py3 only, while resultsdb is py2 only.

Oh, that's a bit annoying. I thought we could get away without keeping Python 2 compatibility here anymore.

Should we use six instead of the except ImportError?

Also, should we port Resultsdb to Python 3? :-)

Should we use six instead of the except ImportError?

I'm indifferent. Your call!

Also, should we port Resultsdb to Python 3? :-)

Yes, but this is an easyfix for now. ;)

Indeed.

Let's avoid a new dependency on six for now, since we only have this one import that needs to differ.

:+1:

Pull-Request has been merged by dcallagh
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.