waiverdb

#157 Fix #148: CLI example in help is not very useful/contains meta-characters
Merged by dcallagh. Opened by fivaldi.
fivaldi/waiverdb master  into  master

Download 157.patch
no initial comment

LGTM.

rebased onto fd047b2d8c969f0fd2613e974accb2d3143c0fc9

@zbyszek I added some fixes for tests/test_cli.py. There was an issue with the dict order between Py2 versus Py3. Side effect was in removing of the #noqa flags.

tox for tests/test_cli.py produces:

  lint: commands succeeded
  py27: commands succeeded
  py34: commands succeeded
  py35: commands succeeded
  py36: commands succeeded
ERROR:   docs: commands failed

Don't know if the docs command is necessary to pass here... (?) But I think it's because of my environment, which is not 100% ready for waiverdb testing.
Edited by fivaldi

Please for last review here after the changes in asserts in tests/test_cli.py.
Edited by fivaldi

Thanks @fivaldi ... I wonder if we should just drop the -r example entirely since that's deprecated. Anyway, this is a good improvement. :+1:

Pull-Request has been merged by dcallagh
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.