waiverdb

#170 remove 'results' filter from GET /api/v1.0/waivers/
Merged by dcallagh. Opened by dcallagh.
dcallagh/waiverdb no-get-results-filter  into  master

Download 170.patch

Strictly this is a compatibility break, but nothing we know of is using
this parameter, and it is quite awkward to use.

Replace it with simple 'subject' and 'testcase' filter parameters,
matching the other existing parameters.

Also fixed some other related stuff while I was in there.

3 new commits added

  • tweak wording of GET /api/v1.0/waivers/ parameters
  • use reqparse properly for 'since' parameter
  • remove 'results' filter from GET /api/v1.0/waivers/

BTW, this can give error {"since": "too many values to unpack"}. Though can probably be understood by users.

This solution would be bit more cleaner.

+1

nice, +1

True although I wasn't planning to change this API, and as the comment notes it matches the API in ResultsDB. So I think there is some value in keeping it.

Oh yeah nice catch. I didn't think of that. Will add a test case and make the error message be nicer.

I will pull the unrelated patches out of this PR, and file them separately with the suggested changes, leaving this to be purely about removing 'results'. It needs a rebase anyway in light of PR#166 which I had forgotten was still pending.

Commit 3b45898 is rebased, other commits are moved to PR#174.

rebased onto 3b45898f254ffa06f088ff7c17b1ccde1872b483

+1

Pull-Request has been merged by dcallagh
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.