From c78df9e0a5eaf633d013ccee20f08effb11a5450 Mon Sep 17 00:00:00 2001 From: Yuxiang Zhu Date: Jul 09 2018 09:26:25 +0000 Subject: Change ENTRYPOINT in Dockerfile to CMD This is not a strong opinion but I would recommend to move the command of starting WaiverDB service in the `Dockerfile` from `ENTRYPOINT` to `CMD` for pursuing the best practices, so that `ENTRYPOINT` can be reserved for container initialization, like confiurating from environment variables, waiting for services, generating keys, or reaping zombie processes. For OpenShift users who overwrite this command, they should overwrite the `args` parameter instead of `command` parameter after this change. --- diff --git a/Dockerfile b/Dockerfile index c005361..5a24f92 100644 --- a/Dockerfile +++ b/Dockerfile @@ -31,4 +31,6 @@ RUN if [ "$cacert_url" != "undefined" ]; then \ USER 1001 EXPOSE 8080 -ENTRYPOINT gunicorn-3 --bind 0.0.0.0:8080 --access-logfile=- --enable-stdio-inheritance waiverdb.wsgi:app +CMD ["/usr/bin/gunicorn-3", "--bind", "0.0.0.0:8080", "--access-logfile", "-", "--enable-stdio-inheritance", "waiverdb.wsgi:app"] + +