Better put this in its own build stage. It's not part of building the SRPM.

@dcallagh this one as well, please, :smile:

You can just invoke python instead of /usr/bin/python.

(We have to invoke /usr/bin/mock with the full path because of the mess with /usr/sbin/mock setuid helper.)

Yeah, I thought there must be a reason to call mock like that. I've updated the PR.

:+1: but ideally test it in Jenkins before merging

👍 but ideally test it in Jenkins before merging

Yeah, that reminds me that I need to get flask-oidc built in eng-rhel-7.

This won't execute with the same rules as the one enforced in tox. You can execute just the lint rule in tox with tox -e lint so it runs with the same rules it runs for developers.

As the doc says, it will run with the rules configured in the tox.ini.
http://flake8.pycqa.org/en/latest/user/configuration.html#configuration-locations

:+1: here.

Whoa, fancy. I've been needlessly duplicating my configuration to setup.cfg. :thumbsup:

I've tested it in Jenkins and it works as expected.