#394 Support scenario field for HTTP API
Merged by vmaljulin. Opened by vmaljulin.
vmaljulin/waiverdb RHELWF-1881  into  master

Download 394.patch
factory2jenkins commented

Build 133bb95b883df891c189f31d4c093fabc3678154 FAILED!
Rebase or make new commits to rebuild.

rebased onto 7ec456401af1b9a57948a97c0a24066d978979f8

factory2jenkins commented

Build 7ec456401af1b9a57948a97c0a24066d978979f8 FAILED!
Rebase or make new commits to rebuild.

Jenkins has been successfully rebuilt (docker limit problem)

@lholecek @gnaponie please review

I'm unsure about this. I'm not sure if we should matter about scenario in this case. Can you explain further why you thought this needed to be changed?

Just a small comment, besides that it looks good +1

I'm unsure about this. I'm not sure if we should matter about scenario in this case. Can you explain further why you thought this needed to be changed?

Cause it makes no sense to use it with a particular result

I'm unsure about this. I'm not sure if we should matter about scenario in this case. Can you explain further why you thought this needed to be changed?

Requesting specific scenario shouldn't be needed if you already are requesting waiver for specific result -- the scenario value from the result data should be used automatically.

As mentioned in the comment above: with result_id, scenario needs to be set according to the result's data, otherwise it would be waiving other results too (same subject and testcase but all other scenarios).

1 new commit added

  • fixup! Support scenario field for HTTP API

rebased onto 9cb706365e8d713c72523c5ded3e13b4ce60f8fa

As mentioned in the comment above: with result_id, scenario needs to be set according to the result's data, otherwise it would be waiving other results too (same subject and testcase but all other scenarios).

added

rebased onto 835c2d5993d8c66c0045c165228aad2c46fd7040

test updated for the scenario field from resultsDB

Pull-Request has been merged by vmaljulin

Metadata