Does this mean, the monkey-patching is only temporary until that Flask issue is solved?

What will the code look like after that is solved? I assume we will always need some kind of hackery in the tests like this, if we want to inject a custom session running in its own transaction that gets rolled back etc.

Nah, I think we can still use this when the Flask issue is resolved as it's using less code and easy for us to inspect the state of the db. Right now, I have to change this options = dict(bind=connection, binds=_dict()) to options = dict(bind=connection) .

What will the code look like after that is solved? I assume we will always need some kind of

Not quite sure what you mean. This is just for patching the global scoped session to use a specific connection. The current code creates a new scoped session when running the tests, so I think it should not matter.

hackery in the tests like this, if we want to inject a custom session running in its own >transaction that gets rolled back etc.

Yeah, we still need to use the workaround for specifying the binds parameter with empty dict when creating a new scoped session. Alternatively, we may be able to monkey-patch the db.create_scoped_session() to get around this issue.

Okay gotcha. I was confused by the word "temporarily" because I thought that meant we were going to change the test fixtures again later. But I guess you mean temporarily as in, for the duration of each test.

:+1: