#430 Fix dependencies used by tox
Merged by lholecek. Opened by lholecek.
lholecek/waiverdb fix-tox  into  master

Download 430.patch

Pins Python libraries to same versions as in Fedora 34.

rebased onto 4a784d455ebba3eb5d186ec383c95ec4eef525b4

rebased onto 59fc9645c5a8f2d58b0da0ecbe2b497a6a6c1aac

Pull-Request has been merged by lholecek

@lholecek Actually I don't how you figure out what kind of requirements and versions are needed, could you show me how you fix it in detail? Thanks.

@lholecek Actually I don't how you figure out what kind of requirements and versions are needed, could you show me how you fix it in detail? Thanks.

This only aligns the problematic dependencies installed by pip to what we have installed in container - base image is Fedora 34 so the versions are same as for python3-*packages there.

We would need to pin all versions of packages in requirements.txt so the same problem won't happen in the future (sudden package update breaks backwards compatibility). This would also help us to check for security vulnerabilities in given version of Python libraries.

Poetry package-manager would help with the pinning. Command poetry add some_package would pin some_package to the latest versions and possibly also resolve any conflicting version requirements for other dependencies.

For implementation in Greenwave see: https://github.com/release-engineering/greenwave/pull/8

Metadata