greenwave

#470 Get the commit hash from koji's extra/source field
Closed: Fixed by vmaljulin. Opened by pingou.

Closed: Fixed
Reopen Issue

According to the discussion in https://lists.fedoraproject.org/archives/list/ci@lists.fedoraproject.org/message/5AIBPJGFCKRC6IDGWSXKOMGNROJICDNW/ greenwave currently gets the commit hash from the source field, however, that field may be referring to the branch name rather than a specific commit.

In order to track exactly which git hash was used to build an artifact, koji has been enhanced to store this information in its extra field, more precisely in "extra": {"source": ...}.
Cf upstream ticket: https://pagure.io/koji/issue/550

Broken by 58cbab67dfa5416c88d3e89f13c2eff0b45e54df.

Maybe let's try a fallback instead.

try:
    source = build['extra']['source']['original_url']
except KeyError:
    source = build.get('source')

Seeing the commit message, should this be considered a koji bug?

Otherwise :thumbsup: for your fallback

The fallback looks fine.
If that's a koji bug, we should file it.
/me has no enough knowledge on koji to know if that's actually a bug.
Does anyone know? If not, I can file it and ask why.

If that's a koji bug, we should file it.
/me has no enough knowledge on koji to know if that's actually a bug.
Does anyone know? If not, I can file it and ask why.

+1 to just open a ticket and ask if this behavior is the expected one :)

Done: https://pagure.io/koji/issue/1607
Let's wait.

Update: it seems like koji wasn't the right place to report that.
New request: https://github.com/containerbuildsystem/koji-containerbuild/issues/129

Let's implement the quick-fix I mentioned in the first comment (fallback to source if extra is not available) and not wait on the resolution for containers.

Commit 1923eb5d fixes this issue
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.