koji

#1240 admin_emails not working
Closed: Fixed by tkopecek. Opened by tkopecek.

Closed: Fixed
Reopen Issue

I suspect, that admin_emails settings in kojid.conf doesn't work as expected. There is no conversion to list during config parsing, so it would create bogus e-mail addresses. (Not tested, but making a placeholder here)

Are you saying this has broken recently? I am currently getting admin emails from 1.16.1 based kojid instances.

The admin_emails option in kojid.conf is just a string. This is passed directly to add_mail_logger, which passes it directly to SMTPHandler, whose __init__ will wrap it in a list if it is a string. This is passed to smtp.sendmail.

Perhaps this will fail if there are multiple addresses separated by commas, but I wouldn't be surprised if it works as is, given the smtp protocol.
Edited by mikem

I don't think it is new, but just for correct passing multiple addresses I would add something like PR #1246. We're just relying on smtplib internal handling which can change without notice.

Metadata Update from @dgregor:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.20

Metadata Update from @jcupova:
- Issue tagged with: testing-done

Metadata Update from @jcupova:
- Issue untagged with: testing-done
- Issue tagged with: testing-ready

Commit 1ddb03dc fixes this issue

Commit 0e504283 fixes this issue

Metadata Update from @jcupova:
- Issue tagged with: testing-done

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1240

Please continue any further discussion there.
Metadata
None

testing-done testing-ready

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.