koji

#2251 Improve volume policy to work with content generators
Closed: Fixed by tkopecek. Opened by tkopecek.

Closed: Fixed
Reopen Issue

Wa want additional test for volume policy to detect CG, so policy can work with that. It an be done in clumsy way even today, but clean test would help

PR #2496

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Note that we already had cg tests in the policy. ~~The limitation was that the policy only had data about cgs during a CGImport call.~~ The above PR extends this by examining data from a build value provided to the policy -- meaning that many more policy events would see that cg data, e.g. a call to applyVolumePolicy (or for that matter tagging policies).

EDITED: policy_get_cgs also checks buildroot data and has since 2016. If that part of the code isn't working, we should fix it.
Edited by mikem

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.24 (was: 1.23)

Metadata Update from @jcupova:
- Issue untagged with: testing-done, testing-ready

After reviewing #2496 again, I'm not sure what is wrong with the existing code. All cg imports, old and new, should have cg info in their buildroot data, and all cg imports should have buildroot data. The existing policy check looks at that buildroot data. I don't quite recall the details of the situation that led to this issue getting filed, but I think we ought to try to demonstrate an example of the behavior we want to change.

Metadata Update from @tkopecek:
- Issue set to the milestone: None (was: 1.24)

Metadata Update from @tkopecek:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Other changes meanwhile fixed most (if not all the issues). Let's close this one for now and open a new one in case there will be some new problematic situation.

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2251

Please continue any further discussion there.
Metadata
None

feature

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.